Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies #3084

Merged
merged 3 commits into from
Oct 2, 2024
Merged

Update dependencies #3084

merged 3 commits into from
Oct 2, 2024

Conversation

nazar-pc
Copy link
Member

@nazar-pc nazar-pc commented Oct 1, 2024

No big surprises here

Code contributor checklist:

@nazar-pc
Copy link
Member Author

nazar-pc commented Oct 1, 2024

Removed subspace-chiapos because it was including blake3 source files directly that was causing symbol conflicts and we have a decent test coverage of our own at this point.

NingLin-P
NingLin-P previously approved these changes Oct 1, 2024
View reviewed changes
teor2345
teor2345 previously approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, thanks!

It's now possible to put dependency versions (and minimal features) in the workspace Cargo.toml, then override features and optional in each crate's Cargo.toml:
https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#inheriting-a-dependency-from-a-workspace
https://doc.rust-lang.org/cargo/reference/workspaces.html#the-dependencies-table

Maybe we could do that at some point in future?

There's a tool which unifies version dependencies (but not path dependencies):
https://mainmatter.com/blog/2024/03/18/cargo-autoinherit/

Base automatically changed from upgrade-substrate to main October 2, 2024 03:25
@nazar-pc nazar-pc dismissed stale reviews from teor2345 and NingLin-P October 2, 2024 03:25

The base branch was changed.

@nazar-pc
Copy link
Member Author

nazar-pc commented Oct 2, 2024

Maybe we could do that at some point in future?

Yeah, probably

@nazar-pc nazar-pc added this pull request to the merge queue Oct 2, 2024
Merged via the queue into main with commit eca3dfe Oct 2, 2024
11 checks passed
@nazar-pc nazar-pc deleted the update-dependencies branch October 2, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teor2345 teor2345 teor2345 approved these changes

@NingLin-P NingLin-P NingLin-P left review comments

@rg3l3dr rg3l3dr Awaiting requested review from rg3l3dr rg3l3dr is a code owner

@shamil-gadelshin shamil-gadelshin Awaiting requested review from shamil-gadelshin shamil-gadelshin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nazar-pc @teor2345 @NingLin-P